Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebFlux temporary file not always deleted with parallel uploads #32482

Conversation

qeeqez
Copy link
Contributor

@qeeqez qeeqez commented Mar 18, 2024

Fixes gh-31217. Delete temp files after multipart exchange

Now temporary files removed as expected and we do not have gigabytes of data stored in temp folder after multipart exchange.

Actual fix is only in DefaultParts.java
All other changes - cleaning temp data after test runs

p.s. @poutsma pull request is for 6.1.x as per assigned milestone

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 18, 2024
@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Mar 18, 2024
@poutsma
Copy link
Contributor

poutsma commented Apr 5, 2024

I thank you for submitting a PR, and I appreciate the help with this issue.

However, by removing the blockingOperation calls, expensive blocking file operations will be scheduled on a non-blocking thread, which would introduce serious performance problems. So despite the fact that this PR resolves #31217, I am afraid that we need to reject it, as merging it would introduce new issues.

@poutsma poutsma closed this Apr 5, 2024
@poutsma poutsma added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants