Reject null return value from MethodReplacer for primitive return type
#32412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeMikaelF Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@LeMikaelF Thank you for signing the Contributor License Agreement! |
sbrannen
added
in: core
sbrannen
changed the title
sbrannen
changed the title
null return value from MethodReplacer for primitive return type
sbrannen
pushed a commit
that referenced
this pull request
Mar 11, 2024
This commit throws an exception instead of silently converting a null return value from a MethodReplacer to a primitive 0/false value. See gh-32412
|
Hi @LeMikaelF, Congratulations on submitting your first PR for the Spring Framework! 👍 This has been merged into Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
MethodReplacerreplaces a method with a primitive return type, and if the replacer returnsnull, CGLIB silently converts thenullto a zero-value primitive (false or 0), instead of throwing an exception (seeCodeEmitter::zero_or_nullin CGLIB).This does not align with the rest of the Spring Framework. For example, the AOP module checks for a
nullin advices for methods with primitive return types before it reaches the CGLIB proxy (CglibAopProxy::processReturnType) and throws anAopInvocationException. Similarly, the AOP module maintains functional parity between the JDKProxyand CGLIB proxies by wrapping an undeclared checked exception in anUndeclaredThrowableException. Moreover, silently converting anullto a non-null value can lead to hard-to-find bugs.MvcUriComponentsBuilder.ControllerMethodInvocationInterceptoralso has this quirk, but the return values of the proxies it returns aren't meant to be used, so I didn't touch that one.This PR follows the pattern used by
CglibAopProxyand throws an exception ifnullis returned in the advice for a method with a primitive return type.