Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct documentation for userDestinationPrefix in MessageBrokerRegistry #32272

Closed
wants to merge 1 commit into from
Closed

Correct documentation for userDestinationPrefix in MessageBrokerRegistry #32272

wants to merge 1 commit into from

Conversation

Xednar
Copy link
Contributor

@Xednar Xednar commented Feb 14, 2024

Changes documentation for setUserDestinationPrefix to match getTargetDestination in DefaultUserDestinationResolver

Current documentation is misleading, because the default implementation appends "-user" + sessionId to the actualDestination

@pivotal-cla This is an Obvious Fix

@Xednar
changes documentation for setUserDestinationPrefix to match getTarget…
5bbc2fa 
…Destination in DefaultUserDestinationResolver
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 14, 2024
rstoyanchev
rstoyanchev reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The targetDestination is for matching source destination that are used to target a user. This is translated to a target destination that is a unique queue name (and does not contain "user" in it.

@rstoyanchev rstoyanchev added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 15, 2024
@rstoyanchev
Copy link
Contributor

Actually, I think you're right on the format of the target destination. My apologies!

@rstoyanchev rstoyanchev reopened this Feb 15, 2024
@rstoyanchev rstoyanchev self-assigned this Feb 15, 2024
@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) type: documentation A documentation task and removed status: invalid An issue that we don't feel is valid labels Feb 15, 2024
@rstoyanchev rstoyanchev added this to the 6.1.5 milestone Feb 15, 2024
@rstoyanchev rstoyanchev changed the title Change misleading docs for setUserDestinationPrefix in MessageBrokerRegistry Correct docs for setUserDestinationPrefix in MessageBrokerRegistry Feb 15, 2024
@rstoyanchev rstoyanchev changed the title Correct docs for setUserDestinationPrefix in MessageBrokerRegistry Correct documentation for userDestinationPrefix in MessageBrokerRegistry Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev left review comments

@jdicke jdicke jdicke approved these changes

Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) type: documentation A documentation task
Projects
None yet
Milestone
6.1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Xednar @rstoyanchev @jdicke @spring-projects-issues