Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple @RequestMapping annotations #32134

Closed
wants to merge 1 commit into from

Conversation

youssef3wi
Copy link

Closes #32043

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 26, 2024
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 1, 2024
@sbrannen sbrannen changed the title Support multiple RequestMapping and HttpExchange annotations Support multiple @RequestMapping annotations Feb 1, 2024
@sbrannen
Copy link
Member

sbrannen commented Feb 1, 2024

Hi @youssef3wi,

Congratulations on submitting your first PR for the Spring Framework! 👍

Unfortunately, this PR introduces breaking changes by renaming protected methods which are effectively part of the public API.

In light of that, I am closing this PR.

In addition, I have added the "pending-design-work" label to #32043 to make it clearer that the team wishes to "investigate the feasibility of supporting multiple @RequestMapping annotations on a single handler method" before. One of the reasons we chose that wording in the issue's description is that we are aware of the fact that existing methods are based on the assumption that there is a single annotation mapping per method.

If you have ideas, feel free to share them on the issue to begin a discussion.

Thanks!

@sbrannen sbrannen closed this Feb 1, 2024
@sbrannen
Copy link
Member

sbrannen commented Feb 1, 2024

As a side note, any PR that wishes to address this topic would need to address it not only in WebFlux but also in Web MVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple @RequestMapping annotations (@GetMapping, etc) on a controller method
3 participants