Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncContext to be completed on AsyncListener.onError() #31953

Conversation

injae-kim
Copy link
Contributor

@injae-kim injae-kim commented Jan 5, 2024

Closes gh-31541

Motivation

According to https://bz.apache.org/bugzilla/show_bug.cgi?id=66875#c11,
our StandardServletAsyncWebRequest.onError implementation should call asyncContext.complete()
if that context is still non-null.
Let's sort this out for 6.1.3 and backport it to 6.0.16 and 5.3.32 from there.
Tomcat's error handling triggers the onError event.
...
Spring and/or the application should be calling complete() or dispatch() as a result of the onError() event.

Modification

  • Fix AsyncContext to be completed on StandardServletAsyncWebRequest.onError()

Result

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 5, 2024
@injae-kim injae-kim force-pushed the fix-asyncListener-onError-asyncContext-complete branch from 0d7d55d to bdccd90 Compare January 5, 2024 12:17
@injae-kim injae-kim changed the title Fix AsyncContext to be completed on AsyncListenr.onError() Fix AsyncContext to be completed on AsyncListener.onError() Jan 5, 2024
@rstoyanchev
Copy link
Contributor

As per #31541 (comment), this is not the fix we want. Thanks for preparing the pull request in any case!

@rstoyanchev rstoyanchev closed this Jan 9, 2024
@rstoyanchev rstoyanchev added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double error response handling on suspended methods
3 participants