Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate key exception error code for SAP HANA database #31554

Conversation

baratrax
Copy link
Contributor

@baratrax baratrax commented Nov 6, 2023

No description provided.

@pivotal-cla
Copy link

@baratrax Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@baratrax Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 6, 2023
@sbrannen sbrannen changed the title Add sap hana duplicate key exception error code Add duplicate key exception error code for SAP HANA database Nov 6, 2023
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 6, 2023
@sbrannen sbrannen added this to the 6.1.x milestone Nov 6, 2023
@jhoeller jhoeller modified the milestones: 6.1.x, 6.0.14 Nov 6, 2023
@jhoeller
Copy link
Contributor

jhoeller commented Nov 6, 2023

Since this matches the Hana error code in sql-error-codes.xml, let's bring this in sync for 6.0.14 - and also update the duplicated check in the R2DBC ConnectionFactoryUtils class accordingly.

@sbrannen sbrannen self-assigned this Nov 6, 2023
@snicoll snicoll assigned snicoll and unassigned sbrannen Nov 7, 2023
snicoll pushed a commit that referenced this pull request Nov 7, 2023
@snicoll snicoll closed this in 7f94c64 Nov 7, 2023
@snicoll
Copy link
Member

snicoll commented Nov 7, 2023

@baratrax thank you for making your first contribution to Spring Framework.

@sbrannen sbrannen assigned sbrannen and unassigned snicoll Nov 7, 2023
sbrannen added a commit that referenced this pull request Nov 7, 2023
sbrannen added a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants