R2DBC: Skip release connection after nested with existing transaction #31133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: data
jhoeller
changed the title
jhoeller
added a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #30134
Switching from my dirty workarround implementation of r2dbc nested transaction to new build-in, I got some test case failure.
After digging, I realize that outer transaction state was lost after completing a nested transaction with existing transaction (i.e. one using a savepoint) through
R2dbcTransactionManager#doCleanupAfterCompletionthat callConnectionFactoryUtils#releaseConnectionandConnectionHolder#clear.This PR try to fix that.
@jhoeller : It would be great if you may have a look (You may see something I miss) ; And thanks a lot for #30134 !