Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DefaultSingletonBeanRegistry.isDependent() #30839

Closed
wants to merge 1 commit into from
Closed

Simplify DefaultSingletonBeanRegistry.isDependent() #30839

wants to merge 1 commit into from

Conversation

bnbakp0582
Copy link
Contributor

@bnbakp0582 bnbakp0582 commented Jul 8, 2023 •
edited by sbrannen
Loading

Move alreadySeen out of for-loop.

@bnbakp0582
Polish DefaultSingletonBeanRegistry
248231c 
move alreadySeen out of for loop
@pivotal-cla
Copy link

@bnbakp0582 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@bnbakp0582 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 8, 2023
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 9, 2023
@sbrannen sbrannen changed the title Polish DefaultSingletonBeanRegistry Simplify DefaultSingletonBeanRegistry.isDependent() Jul 9, 2023
@sbrannen sbrannen self-assigned this Jul 9, 2023
@sbrannen sbrannen added this to the 6.0.11 milestone Jul 9, 2023
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Jul 9, 2023
@sbrannen
Further simplify DefaultSingletonBeanRegistry.isDependent()
502997d 
See spring-projectsgh-30839
@sbrannen sbrannen closed this in fb4ad2f Jul 9, 2023
@sbrannen
Copy link
Member

sbrannen commented Jul 9, 2023

Hi @bnbakp0582,

This has been merged into 6.0.x and main in fb4ad2f and revised in 502997d.

Thanks

@sbrannen sbrannen mentioned this pull request Jul 9, 2023
Closed
@sbrannen sbrannen added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Jul 9, 2023
@bnbakp0582 bnbakp0582 deleted the patch-1 branch July 9, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@bnbakp0582 @pivotal-cla @sbrannen @jhoeller @spring-projects-issues