Fix log level on error with @TransactionalEventListener #30776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KSH-code Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@KSH-code Thank you for signing the Contributor License Agreement! |
KSH-code
changed the title
KSH-code
changed the title
jhoeller
added
in: data
jhoeller
added
for: backport-to-5.3.x
status: backported
|
Good point, it is not clear why that log level got downgraded to debug, this might have been an accident indeed. While regular transaction synchronizations are not meant to throw an exception there to begin with, this may certainly happen for transactional event processing and should be visible there. |
jhoeller
added a commit
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronous methods with
@TransactionalEventListenerlogs in debug level.However, most production logs are filtered by error level. Thus most developers cannot detect
@TransactionalEventListenermethod throws error whether or not.It was changed from 95110d8. I think this changed an error because it is not related to commit message.
ref: #17162