Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MultipartFileArgumentResolver for HTTP interface client #30728

Closed
wants to merge 3 commits into from
Closed

Add MultipartFileArgumentResolver for HTTP interface client #30728

wants to merge 3 commits into from

Conversation

OlgaMaciaszek
Copy link
Contributor

@OlgaMaciaszek OlgaMaciaszek commented Jun 22, 2023 •
edited
Loading

  • add tests
  • add more javadocs

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 22, 2023
@rstoyanchev rstoyanchev self-assigned this Jun 23, 2023
@rstoyanchev rstoyanchev added this to the 6.1.0-M2 milestone Jun 23, 2023
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 23, 2023
@rstoyanchev rstoyanchev mentioned this pull request Jun 23, 2023
Closed
@rstoyanchev rstoyanchev changed the title Add MultipartFileArgumentResolver. Add MultipartFileArgumentResolver for HTTP interface client Jun 23, 2023
@OlgaMaciaszek OlgaMaciaszek force-pushed the add-multipart-file-argument-resolver branch from 7c4d0b6 to 925454a Compare June 23, 2023 15:00
@OlgaMaciaszek
Copy link
Contributor Author

Fixes gh-30342.

@OlgaMaciaszek OlgaMaciaszek marked this pull request as ready for review June 23, 2023 15:01
rstoyanchev
rstoyanchev requested changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Some minor comments below.

...web/src/main/java/org/springframework/web/service/invoker/MultipartFileArgumentResolver.java Outdated Show resolved Hide resolved
...web/src/main/java/org/springframework/web/service/invoker/MultipartFileArgumentResolver.java Outdated Show resolved Hide resolved
...web/src/main/java/org/springframework/web/service/invoker/MultipartFileArgumentResolver.java Show resolved Hide resolved
rstoyanchev
rstoyanchev approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, and for adding an integration test.

rstoyanchev pushed a commit that referenced this pull request Jun 27, 2023
@OlgaMaciaszek @rstoyanchev
Add MultipartFile support to HTTP interface client
e69a1d2 
See gh-30728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev approved these changes

Assignees

@rstoyanchev rstoyanchev

@OlgaMaciaszek OlgaMaciaszek

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@OlgaMaciaszek @rstoyanchev @spring-projects-issues