Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing long dates in InstantFormatter #30546

Merged
merged 3 commits into from
May 26, 2023
Merged

Support parsing long dates in InstantFormatter #30546

merged 3 commits into from
May 26, 2023

Conversation

RemusRD
Copy link
Contributor

@RemusRD RemusRD commented May 25, 2023 •
edited by sbrannen
Loading

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 25, 2023
@RemusRD RemusRD mentioned this pull request May 25, 2023
Closed
@RemusRD
Copy link
Contributor Author

RemusRD commented May 25, 2023

See #30312

@sbrannen sbrannen changed the title Fixes #30312 - Support parsing long dates in InstantFormatter. Support parsing long dates in InstantFormatter May 25, 2023
@sbrannen sbrannen changed the title Support parsing long dates in InstantFormatter Support parsing long dates in InstantFormatter May 25, 2023
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement status: waiting-for-triage An issue we've not yet triaged or decided on and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 25, 2023
@sbrannen sbrannen requested a review from simonbasle May 25, 2023 11:34
@RemusRD
Copy link
Contributor Author

RemusRD commented May 25, 2023

Fixing the linting shortly!

@RemusRD @simonbasle
Update spring-context/src/test/java/org/springframework/format/dateti…
314d59d 
…me/standard/InstantFormatterTests.java

Co-authored-by: Simon Baslé <[email protected]>
@simonbasle simonbasle removed the status: waiting-for-triage An issue we've not yet triaged or decided on label May 25, 2023
@simonbasle simonbasle added this to the 6.1.0-M1 milestone May 25, 2023
@RemusRD
Copy link
Contributor Author

RemusRD commented May 25, 2023

Wondering if the formatting shouldn't have been done by my Intellij IDEA? Maybe I have something not configured properly? Or is there any gradle task to format the code?

@simonbasle
Copy link
Contributor

Wondering if the formatting shouldn't have been done by my Intellij IDEA? Maybe I have something not configured properly? Or is there any gradle task to format the code?

Thanks for fixing the formatting. There isn't really a Gradle task, but there is some guidance in the CONTRIBUTING.md pointing to wiki pages. There's also a .editorconfig at the root of the project and some exported settings in src/idea.

@simonbasle simonbasle merged commit 4d8f6c1 into spring-projects:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle left review comments

Assignees

@simonbasle simonbasle

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@RemusRD @simonbasle @sbrannen @spring-projects-issues