Fix migration to asciidoctor tabs #30435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The automation to asciidoctor tabs did not migrate properly for all cases this commit fixes the migration.
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
type: task
|
I think this applies to 6.0.x as well. I'll rebase it on 6.0.x before merging. |
|
@rstoyanchev You are right. I messed up which branch to target. I've updated it to point at 6.0.x now. |
rstoyanchev
pushed a commit
that referenced
this pull request
May 9, 2023
The automation to asciidoctor tabs did not migrate properly for all cases this commit fixes the migration. See gh-30435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automation to asciidoctor tabs did not migrate properly for all cases this commit fixes the migration.
For example, this does not properly render as tabs due to the migration not working properly.