Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-null precondition checks in DefaultEntityResponseBuilder #30433

Closed
wants to merge 4 commits into from

Conversation

srivatsa-cfp
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 5, 2023
@srivatsa-cfp
Copy link
Contributor Author

@poutsma can you please review this PR

@poutsma poutsma self-assigned this Jun 13, 2023
@sbrannen sbrannen changed the title additional null validations for Entity builder Add non-null precondition checks in DefaultEntityResponseBuilder Jun 13, 2023
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 14, 2023
@poutsma poutsma added this to the 6.1.0-M1 milestone Jun 14, 2023
@poutsma poutsma closed this in 0c817f0 Jun 14, 2023
poutsma added a commit that referenced this pull request Jun 14, 2023
* gh-30433:
  Polishing external contribution
  Add non-null assertions in DefaultEntityResponseBuilder
@poutsma
Copy link
Contributor

poutsma commented Jun 14, 2023

Merged, thank you.

I did remove the latter two null checks, because they were unnecessary. Any equals method should be able to deal with null parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants