Fix publishing of PayloadApplicationEvents in parent context #30420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a more defensive propagation of an event and the optionally associated eventType when calling `publishEvent`, especially when a parent context is present. Notably, it avoids a situation where the parent `publishEvent` call would generate a new `PayloadApplicationEvent` with the wrong eventType (`PayloadApplicationEvent<PayloadApplicationEvent<T>>`). This commit also adds test coverage (which includes cases where an event is fired before the multicaster is set) and a defensive check against inconsistent publishing of a PayloadApplicationEvent (even though that is something that is expected to be done mostly internally by the framework). Closes spring-projectsgh-30360
simonbasle
added
type: regression
simonbasle
added
the
status: declined
|
superseded by e228f4b |
simonbasle
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a more defensive propagation of an event
and the optionally associated eventType when calling
publishEvent,especially when a parent context is present.
Notably, it avoids a situation where the parent
publishEventcallwould generate a new
PayloadApplicationEventwith the wrong eventType(
PayloadApplicationEvent<PayloadApplicationEvent<T>>).This commit also adds test coverage (which includes cases where an event
is fired before the multicaster is set) and a defensive check against
inconsistent publishing of a PayloadApplicationEvent (even though that
is something that is expected to be done mostly internally by the
framework).
See gh-30360
Closes gh-30420