-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the reference documentation to Antora #30414
Closed
+70,269
−62,124
Closed
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
00a08da
Remove core- prefix from .adoc files
rwinch 4730900
Remove data-access- prefix from .adoc files
rwinch b1ceee4
Remove integration- prefix from .adoc files
rwinch 2bb9c17
Remove -languages suffix from .adoc files
rwinch 4d4e5c2
Remove duplicated testing from .adoc file path
rwinch 6320416
Migrate Structure
rwinch 34856b3
Insert explicit ids for headers
rwinch c346e73
Remove unnecessary asciidoc attributes
rwinch eb37a2e
Fix image::image
rwinch c6fae52
Copy default antora files
rwinch 99ccdba
Split files
rwinch 385800e
Generate a default navigation
rwinch 3b68f5e
Remove includes
rwinch 8496778
Fix cross references
rwinch 8ed1245
Enable Section Summary TOC for small pages
rwinch 987ebed
fix framework-docs.gradle
rwinch d3de886
Fix antora.yml gradle command
rwinch 894c6e0
fix antora.yml attributes
rwinch 198b054
Fix invalid attributes
rwinch 7b1cdae
Fix index Overview link
rwinch 616cdd3
Fix invalid nav elements
rwinch a26fde0
Use include-code Macro
rwinch e95e907
Fix Title in antora.yml
rwinch 2ed58ec
Make local build (temporary)
rwinch ac270ec
Trim IDs with parent
rwinch e23d2fa
Structural Fixes
rwinch 04433c5
Add ./github/workflow/deploy-docs.yml
rwinch a8ba7e7
Migrate to Asciidoctor Tabs
rwinch 5abc829
Use the shared antora playbook
rwinch de738e8
Remove invalid deploy-docs.yml
rwinch 5e43a7a
Fix Web Reactive link on the landing page
rwinch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: Deploy Docs | ||
on: | ||
push: | ||
branches-ignore: [ gh-pages ] | ||
tags: '**' | ||
repository_dispatch: | ||
types: request-build-reference # legacy | ||
schedule: | ||
- cron: '0 10 * * *' # Once per day at 10am UTC | ||
workflow_dispatch: | ||
permissions: | ||
actions: write | ||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
if: github.repository_owner == 'spring-projects' | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
with: | ||
ref: docs-build | ||
fetch-depth: 1 | ||
- name: Dispatch (partial build) | ||
if: github.ref_type == 'branch' | ||
env: | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: gh workflow run deploy-docs.yml -r $(git rev-parse --abbrev-ref HEAD) -f build-refname=${{ github.ref_name }} | ||
- name: Dispatch (full build) | ||
if: github.ref_type == 'tag' | ||
env: | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: gh workflow run deploy-docs.yml -r $(git rev-parse --abbrev-ref HEAD) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,3 +50,5 @@ atlassian-ide-plugin.xml | |
|
||
# VS Code | ||
.vscode/ | ||
|
||
cached-antora-playbook.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: framework | ||
version: true | ||
title: Spring Framework | ||
nav: | ||
- modules/ROOT/nav.adoc | ||
ext: | ||
collector: | ||
run: | ||
command: gradlew -q -PbuildSrc.skipTests=true "-Dorg.gradle.jvmargs=-Xmx3g -XX:+HeapDumpOnOutOfMemoryError" :framework-docs:generateAntoraResources | ||
local: true | ||
scan: | ||
dir: ./build/generated-antora-resources | ||
|
||
asciidoc: | ||
attributes: | ||
attribute-missing: 'warn' | ||
# FIXME: the copyright is not removed | ||
# FIXME: The package is not renamed | ||
chomp: 'all' | ||
include-java: 'example$docs-src/main/java/org/springframework/docs' | ||
spring-framework-main-code: 'https://github.com/spring-projects/spring-framework/tree/main' | ||
docs-site: 'https://docs.spring.io' | ||
docs-spring: "{docs-site}/spring-framework/docs/{spring-version}" | ||
docs-spring-framework: '{docs-site}/spring-framework/docs/{spring-version}' | ||
api-spring-framework: '{docs-spring-framework}/javadoc-api/org/springframework' | ||
docs-graalvm: 'https://www.graalvm.org/22.3/reference-manual' | ||
docs-spring-boot: '{docs-site}/spring-boot/docs/current/reference' | ||
docs-spring-gemfire: '{docs-site}/spring-gemfire/docs/current/reference' | ||
docs-spring-security: '{docs-site}/spring-security/reference' | ||
gh-rsocket: 'https://github.com/rsocket' | ||
gh-rsocket-extensions: '{gh-rsocket}/rsocket/blob/master/Extensions' | ||
gh-rsocket-java: '{gh-rsocket}/rsocket-java{gh-rsocket}/rsocket-java' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.49 KB
framework-docs/modules/ROOT/assets/images/aop-proxy-plain-pojo-call.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+78.2 KB
framework-docs/modules/ROOT/assets/images/message-flow-broker-relay.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+63.8 KB
framework-docs/modules/ROOT/assets/images/message-flow-simple-broker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest an allow-list of exact branches to consider, rather than
branches-ignore
.Similarly, I would suggest restricting the
tags
to something like'v[0-9]+.[0-9]+.[0-9]+'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I'm wondering if maintaining this list, or even ignoring
gh-pages
, is worth it given that the logic to decide if a workflow event is triggered is:I view the
branches-ignore
attribute as a redundancy since unless someone merges the workflow into a branch or tag that you want to exclude, the workflow will not be considered. Excludinggh-pages
is fairly simple, but maintaining a list of tags and branches (or expression/s that does the same) to include seems unnecessary overhead given that the workflow file will not be present.Is there a specific concern you have here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged the changes in for now. Let's take this as a follow-up if needed, depending on the outcome of the discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. No specific concern, just a habit I got.
I guess for the framework team it doesn't happen that often that a branch would be created in the original repository, although we do have a couple of leftover branches.
But I guess if such a branch was created (e.g. for an experiment) it would have the file unless if it is an orphan branch (like
docs-build
).There's the
if: github.repository_owner
check lower in the jobs which should broadly prevent any abuse from forks, so this should be fine from that perspective.