Optimize DefaultLifecycleProcessor::stopBeans #30361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stopBeans method.
spring-projects-issues
added
the
status: waiting-for-triage
aooohan
changed the title
simonbasle
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
👍 This is similar to changes made to startBeans in #25506 and since the LifecycleGroupMember phases map is created right before iteration, there shouldn't be any change in phase within the group's members
simonbasle
added
type: enhancement
simonbasle
changed the title
|
LGTM. I've added some polish to the javadoc since it was making references to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize
DefaultLifecycleProcessorby reducing sorting and refactorstopBeansmethod.Do this change due to
LifecycleGrouphas been sorted and member in which has same phase, so resortLifecycleGroupMemberlist to be meaningless.If any improvements can do, feel free to tell me.