Clarify behavior of the Elvis SpEL operator in documentation #30352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
added
type: documentation
|
|
sbrannen
requested changes
Apr 19, 2023
spring-expression/src/main/java/org/springframework/expression/spel/ast/Elvis.java
Outdated
Show resolved
Hide resolved
spring-expression/src/main/java/org/springframework/expression/spel/ast/Elvis.java
Outdated
Show resolved
Hide resolved
This commit improves both the javadoc and the reference guide section on the Elvis SpEL operator to clarify that in addition to `null` objects, empty Strings also lead the operator to evaluate to its second operand. The reference guide's advanced snippet is modified to use such an empty String instead of `null` to make that behavior prominent with some code. See spring-projectsgh-30318 Closes spring-projectsgh-30352
Co-authored-by: Sam Brannen <[email protected]>
simonbasle
force-pushed
the
improveElvisDocumentation
branch
from
ac22dc8 to
af35aa2
Compare
|
Rebased on top of Antora changes, ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves both the javadoc and the reference guide section on
the Elvis SpEL operator to clarify that in addition to
nullobjects,empty Strings also lead the operator to evaluate to its second operand.
The reference guide's advanced snippet is modified to use such an empty
String instead of
nullto make that behavior prominent with some code.See gh-30318
Closes gh-30352