Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimpleJdbcCall named parameter binding for Sybase ASE #30231

Merged

Conversation

giuseppemilicia
Copy link
Contributor

@giuseppemilicia giuseppemilicia commented Mar 29, 2023

This commit fixes an issue with Sybase named parameter binding in the code. The namedParamBindingToUse method has been updated to properly handle named parameters in Sybase stored procedures. Prior to this fix, the method may not have returned the correct named parameter for a given parameter name, causing issues with stored procedure execution.

This fix is necessary to ensure proper execution of Sybase stored procedures that use named parameters.

When working with Sybase ASE stored procedures, parameters should be supplied in the order of their create procedure statement, unless they are supplied in the form @<parameter> = <value>, in which case they can be supplied in any order. For more information, see the Sybase ASE documentation: https://help.sap.com/docs/SAP_ASE/b65d6a040c4a4709afd93068071b2a76/aa8728babc2b101491a4f578b9082925.html?locale=en-US

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 29, 2023
@giuseppemilicia giuseppemilicia changed the title Fix Sybase SimpleJdbcCall named parameter binding Fix Sybase ASE SimpleJdbcCall named parameter binding Mar 29, 2023
@rstoyanchev rstoyanchev added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Apr 11, 2023
@snicoll
Copy link
Member

snicoll commented Sep 28, 2023

I wonder if that PR could also help with #26072

@sbrannen sbrannen changed the title Fix Sybase ASE SimpleJdbcCall named parameter binding Fix SimpleJdbcCall named parameter binding for Sybase ASE Sep 28, 2023
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 20, 2023
@jhoeller jhoeller added this to the 6.1.x milestone Nov 20, 2023
@jhoeller jhoeller self-assigned this Nov 20, 2023
@jhoeller jhoeller modified the milestones: 6.1.x, 6.1.2 Nov 21, 2023
@jhoeller jhoeller merged commit 748dd94 into spring-projects:main Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants