Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all exceptions for stored proc output param retrieval in SharedEntityManagerCreator #30161

Closed
wants to merge 1 commit into from
Closed

Handle all exceptions for stored proc output param retrieval in SharedEntityManagerCreator #30161

wants to merge 1 commit into from

Conversation

giuseppemilicia
Copy link
Contributor

@giuseppemilicia giuseppemilicia commented Mar 22, 2023 •
edited by sbrannen
Loading

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 22, 2023
@sbrannen sbrannen self-assigned this Mar 22, 2023
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 22, 2023
@sbrannen sbrannen added this to the 6.0.8 milestone Mar 22, 2023
@sbrannen
Copy link
Member

sbrannen commented Mar 22, 2023 •
edited
Loading

Hi @giuseppemilicia,

Congratulations on submitting your first PR for the Spring Framework! 👍

For future reference:

  • Please do not submit an issue and a PR, since we will close the issue as superseded by the PR. That avoids extra work for you and the team.
    • Also, if you are planning on submitting a PR after creating an issue, please inform us. I had already created a backport issue and was planning on doing the work myself.
  • Please do not create a PR with a title like "Closes xyz". Instead, always use a descriptive title. Otherwise, the PR may get overlooked.
  • Please include an appropriate commit message in your commits.

In general, follow the guidelines in CONTRIBUTING.

@sbrannen sbrannen changed the title Closes gh-30160 Handle all exceptions for stored proc output param retrieval in SharedEntityManagerCreator Mar 22, 2023
This was referenced Mar 22, 2023
Closed
Closed
@sbrannen sbrannen added the status: backported An issue that has been backported to maintenance branches label Mar 22, 2023
@sbrannen sbrannen closed this in 24b359d Mar 22, 2023
@sbrannen
Copy link
Member

This has been merged into main with an appropriate commit message and backported to 5.3.x.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
6.0.8
Development

Successfully merging this pull request may close these issues.

SharedEntityManagerCreator does not handle all exceptions for stored proc output param retrieval
3 participants
@giuseppemilicia @sbrannen @spring-projects-issues