Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor in link to "Web on Reactive Stack" chapter #30158

Closed
wants to merge 1 commit into from

Conversation

shitian9
Copy link
Contributor

handle <<web-reactive.adoc#spring-webflux(Anchor doesn't resolve), Web Reactive>>

handle <<web-reactive.adoc#spring-webflux, Web Reactive>>(Anchor doesn't resolve)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 22, 2023
@sbrannen sbrannen self-assigned this Mar 22, 2023
@sbrannen
Copy link
Member

For the current documentation, the "Web Reactive" link works fine.

In light of that, I am closing this issue.

If you are reporting something different, please provide additional input.

@sbrannen sbrannen closed this Mar 22, 2023
@sbrannen sbrannen added type: documentation A documentation task status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 22, 2023
@sbrannen
Copy link
Member

For the current documentation, the "Web Reactive" link works fine.

Actually, I now see the point you were making.

The link effectively works fine, since it goes to the beginning on that chapter, which is the intent.

However, you are correct: the #spring-webflux anchor does not exist and should be replaced with #spring-web-reactive.

In light of that, I am reopening this PR.

@sbrannen sbrannen reopened this Mar 22, 2023
@sbrannen sbrannen removed the status: invalid An issue that we don't feel is valid label Mar 22, 2023
@sbrannen sbrannen changed the title Update doc Fix anchor in link to "Web on Reactive Stack" chapter Mar 22, 2023
@sbrannen sbrannen added this to the 6.0.8 milestone Mar 22, 2023
@sbrannen sbrannen added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Mar 22, 2023
@sbrannen sbrannen closed this in 570d21e Mar 22, 2023
@sbrannen
Copy link
Member

This has been merged into main and backported to 5.3.x.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants