Remove extra copy of headers/cookies in WebClient #30092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: web
rstoyanchev
removed
the
status: waiting-for-triage
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Mar 14, 2023
|
Thanks for the suggestion. I have added an extra small refactoring, eliminating the intermediate |
|
@rstoyanchev thank you, could you please consider the sibling PR to this one #29972? that one has more performance gains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the reactive webclient with default headers (and cookies) AND headers (and cookies) specified at the request level, there is an additional intermediate map created prior to copying to the final ClientRequest. I believe this can be eliminated in the changes proposed here.
Here is part of the icicle graph of memory allocations:
The stuff done in the middle section should go away and be done on the right. Additionally, the fixes in #29972 will improve the forEach and ReadOnlyHttpHeaders performance.
The final copy into the ClientRequest used
addAllbut I usedputAllon the defaults and request-provided values in order to preserve the order of operations. Since it appears that nothing else is setting the headers/cookies on that ClientRequest.Builder using add vs put should not matter.