Add SpEL support for registered MethodHandles #30045
Conversation
simonbasle
added
in: core
| for (int i = 0; i < arguments.length; i++) { | ||
| Class<?> argumentClass = methodHandleArgumentTypes.parameterType(i); | ||
| ResolvableType resolvableType = ResolvableType.forClass(argumentClass); | ||
| TypeDescriptor targetType = new TypeDescriptor(resolvableType, argumentClass, null); |
There was a problem hiding this comment.
here the subtle difference compared to the older convertAllMethodArguments higher in the source file is that we get TypeDescriptor out of a raw Class only (vs a MethodParam obtained via reflection with MethodParameter.forExecutable)
|
@ericbottard if you're still interested, feel free to test that out and validate this covers your original use case 😉 |
|
A quick glance at the docs and test tells me this would have been useful. We went with another route (and that leaked in the exposed API sadly), but glad to see this got supported eventually. Thanks! |
This commit adds support for MethodHandles in SpEL, using the same syntax as user-defined functions (which also covers reflective Methods). The most benefit is expected with handles that capture a static method with no arguments, or with fully bound handles (where all the arguments have been bound, including a target instance as first bound argument if necessary). Partially bound MethodHandle should also be supported. A best effort approach is taken to detect varargs as there is no API support to determine if an argument is a vararg or an explicit array, unlike with Method. Argument conversions are also applied. Finally, array repacking is not always necessary with varargs so it is only performed when the vararg is the sole argument to the invoked method. See spring-projectsgh-27099 Closes spring-projectsgh-30045
simonbasle
force-pushed
the
27099-spelMethodHandle
branch
from
203ab5f to
88a5167
Compare
|
Now rebased on top of latest reference doc changes (Antora) and squashed into a single commit. |
|
Is it possible to backport this feature to 5.x? Java 17 is not ready in many environments. |
@fanthos this is very unlikely. We don't backport purely new features to the 5.3.x line, and now that the work has started on 6.1.x, we tend to avoid doing so in 6.0.x as well. edit: got confused, |
This commit adds support for MethodHandles in SpEL, using the same
syntax as user-defined functions (which also covers reflective Methods).
The most benefit is expected with handles that capture a static method
with no arguments, or with fully bound handles (where all the arguments
have been bound, including a target instance as first bound argument
if necessary). Partially bound MethodHandle should also be supported.
A best effort approach is taken to detect varargs as there is no API
support to determine if an argument is a vararg or an explicit array,
unlike with Method. Argument conversions are also applied. Finally,
array repacking is not always necessary with varargs so it is only
performed when the vararg is the sole argument to the invoked method.
Closes gh-27099
Closes gh-30045