-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CharBufferDecoder #29741
Closed
markusheiden
wants to merge
14
commits into
spring-projects:main
from
markusheiden:charbuffer-decoder
Closed
Add CharBufferDecoder #29741
markusheiden
wants to merge
14
commits into
spring-projects:main
from
markusheiden:charbuffer-decoder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Dec 25, 2022
Could you link to that comment, please? |
Lines 76 to 77 in 42b1659
|
rstoyanchev
added
in: web
Issues in web modules (web, webmvc, webflux, websocket)
in: core
Issues in core modules (aop, beans, core, context, expression)
labels
Jan 24, 2023
poutsma
added a commit
that referenced
this pull request
Sep 19, 2023
Created abstract CharSequence decoder, which is extended by StringDecoder and CharBufferDecoder. See gh-29741
poutsma
removed
the
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Sep 19, 2023
It took us a while to resolve, but thank you for submitting a PR! In order to reduce code duplication between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the optimization mentioned in a comment in the Jackson2JsonDecoder.