Adapt FieldHint to recent GraalVM versions #29130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: enhancement
snicoll
changed the title
snicoll
pushed a commit
to snicoll/spring-framework
that referenced
this pull request
Sep 10, 2022
In recent GraalVM versions, allowWrite and allowUnsafeAccess have been deprecated and are no longer use. This commit updates FieldHint to remove the irrelevant properties. See spring-projectsgh-29130
snicoll
added a commit
to snicoll/spring-framework
that referenced
this pull request
Sep 10, 2022
|
Thank you @sreenath-tm. I've looked at the PR and implemented the remaining bits, see e6fb3b2. I'll have a look Monday to get this merged. |
|
Thanks @snicoll pleasure to have worked on this part. |
snicoll
pushed a commit
to snicoll/spring-framework
that referenced
this pull request
Sep 12, 2022
In recent GraalVM versions, allowWrite and allowUnsafeAccess have been deprecated and are no longer use. This commit updates FieldHint to remove the irrelevant properties. See spring-projectsgh-29130
snicoll
added a commit
to snicoll/spring-framework
that referenced
this pull request
Sep 12, 2022
snicoll
pushed a commit
that referenced
this pull request
Sep 12, 2022
In recent GraalVM versions, allowWrite and allowUnsafeAccess have been deprecated and are no longer use. This commit updates FieldHint to remove the irrelevant properties. See gh-29130
snicoll
added a commit
that referenced
this pull request
Sep 12, 2022
|
@sreenath-tm thank you for making your first contribution to Spring Framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #29047 removed the class FieldHint and replaced all instances with a String Set . @snicoll please feel free to add on to this or modify it completely if anything is not as expected