Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to Javadoc for Throwing*.of factory methods #29113

Closed
wants to merge 1 commit into from
Closed

Add examples to Javadoc for Throwing*.of factory methods #29113

wants to merge 1 commit into from

Conversation

Nheyll
Copy link
Contributor

@Nheyll Nheyll commented Sep 8, 2022

@Nheyll Nheyll changed the title Add examples to Javadoc Add examples to Javadoc for Throwing*.of factory methods Sep 8, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 8, 2022
@sbrannen
Copy link
Member

sbrannen commented Sep 9, 2022

Thanks for the PR.

Please note, however, that #28969 was assigned to @philwebb before you submitted the PR since the team had already decided that he would update the Javadoc.

In the future, please do not submit a PR for an assigned issue without first asking if an external contribution is desired.

Also, the examples in this PR are not exactly what we had in mind. Rather, we plan to add examples that are more concrete and enlightening than the technical ones proposed here.

In light of that, we might close this PR, but I will assign it to @philwebb and leave it up to him.

@sbrannen sbrannen marked this pull request as draft September 9, 2022 13:09
@sbrannen sbrannen requested a review from philwebb September 9, 2022 13:09
@philwebb
Copy link
Member

philwebb commented Sep 9, 2022

Thanks very much for the PR @Nheyll, the second examples in your Javadoc was quite close to what I had in mind. In the end I wanted a bit more text around why you'd want to use the methods so I've gone with this update.

Sorry your PR didn't get merged this time, but thanks anyway for your efforts.

@philwebb philwebb closed this Sep 9, 2022
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 9, 2022
@philwebb philwebb removed their request for review September 9, 2022 16:37
@Nheyll Nheyll deleted the add-examples-to-javadoc branch September 10, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants