Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage of RdbmsOperation #28472

Closed
wants to merge 2 commits into from
Closed

Improve test coverage of RdbmsOperation #28472

wants to merge 2 commits into from

Conversation

JiayiLi1999
Copy link

  1. getSql()
  2. tooManyMapParameters()

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 18, 2022
@snicoll snicoll changed the title Add two basic test cases in RdbmsOperationTests.java Improve test coverage of RdbmsOperation Jul 29, 2022
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 29, 2022
@snicoll snicoll self-assigned this Jul 29, 2022
@snicoll snicoll added this to the 6.0.0-M6 milestone Jul 29, 2022
snicoll pushed a commit that referenced this pull request Jul 29, 2022
@snicoll
Improve test coverage of RdbmsOperation
608be54 
See gh-28472
snicoll added a commit that referenced this pull request Jul 29, 2022
@snicoll
Polish "Improve test coverage of RdbmsOperation"
f9ee8a9 
See gh-28472
@snicoll snicoll closed this in 7b4a37f Jul 29, 2022
@snicoll
Copy link
Member

snicoll commented Jul 29, 2022

Thank you for making your first contribution to Spring Framework, @JiayiLi1999.

I didn't include the SQL test as it's testing the getter and we prefer to test the outcome of setting the property. I've also noticed that some tests were not testing what they were supposed to (including the test you added) as the DataSource was not set (so it was failing, but not for the reason that the test was expecting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahadevshindhe mahadevshindhe mahadevshindhe approved these changes

Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

Successfully merging this pull request may close these issues.
4 participants
@JiayiLi1999 @snicoll @mahadevshindhe @spring-projects-issues