Support multiple segments in encoded Content-Disposition #28236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lxbzmy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@lxbzmy Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
lxbzmy
changed the title
lxbzmy
changed the title
poutsma
added
the
in: web
poutsma
changed the title
poutsma
pushed a commit
that referenced
this pull request
Apr 29, 2022
poutsma
added a commit
that referenced
this pull request
Apr 29, 2022
* gh-28236: Polish contribution & Support multiple quoted printable segments in Content-Disposition Support multiple base64 segments in Content-Disposition
|
Thank you for submitting a PR! I have made some minor improvements, and also added support for multiple quoted printable segments. See efafccd. |
sbrannen
removed
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Rfc6266 / Appendix C.1 RFC 2047 (MIME Part Three: Message Header Extensions for Non-ASCII Text), Section 2. Syntax of encoded-words ( page 3 ) :
Original pull request : #26463 , try to decode base64 encoded filename, but he forget there is more segments case.
And thanks @guangtuan find it.