Add CacheErrorHandler implementation that logs exceptions rather than rethrowing them #27826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Drezir
force-pushed
the
feature/issue-27788
branch
from
7e8b3d1 to
9390fe5
Compare
snicoll
added
type: enhancement
snicoll
requested changes
Jan 12, 2022
...ng-context/src/main/java/org/springframework/cache/interceptor/LoggingCacheErrorHandler.java
Outdated
Show resolved
Hide resolved
| * Construct new {@link LoggingCacheErrorHandler} that may log stacktraces. | ||
| * @param includeStacktrace whether to log or not log stacktraces. | ||
| */ | ||
| public LoggingCacheErrorHandler(boolean includeStacktrace) { |
There was a problem hiding this comment.
It would be nice to have a constructor that takes a Logger. This way you can easily provide a mock and test the behavior.
There was a problem hiding this comment.
I have added builder pattern and two test cases. Should tests cover each handler method or does this suffice?
...ng-context/src/main/java/org/springframework/cache/interceptor/LoggingCacheErrorHandler.java
Outdated
Show resolved
Hide resolved
Sure, I will do it. |
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Jan 26, 2022
snicoll
added a commit
that referenced
this pull request
Jan 26, 2022
|
@Drezir thanks for the follow-up. |
sbrannen
added
the
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #27788
I have some more configurable version prepared but I think it is too much (see attachment)
configurable-version.zip
e