Avoid unescape when CONNECT and CONNECTED frames #27722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rygh4775 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@rygh4775 Thank you for signing the Contributor License Agreement! |
rstoyanchev
added
in: messaging
rstoyanchev
pushed a commit
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced an error that stomp websocket client can not send a header with backslash.
Then I found reason.
StopmEncoder dose not escape headers when CONNECT and CONNECTED frames, to follow the spec below:
https://stomp.github.io/stomp-specification-1.2.html#Value_Encoding
However, StompDecoder try to unescape when CONNECT and CONNECTED frames.
StopmDecoder should not unescape when CONNECT and CONNECTED frames, because the frames are not escaped.