Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Javadoc tags #26967

Closed
wants to merge 1 commit into from
Closed

Conversation

izeye
Copy link
Contributor

@izeye izeye commented May 22, 2021

This PR fixes broken Javadoc tags.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 22, 2021
@sbrannen sbrannen self-assigned this May 22, 2021
@sbrannen sbrannen added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 22, 2021
@sbrannen sbrannen added this to the 5.3.8 milestone May 22, 2021
@sbrannen
Copy link
Member

Out of curiosity, how did you notice all of those broken tags?


Regarding the Javadoc for org.springframework.asm.ClassWriter, the following is our policy on changes to the ASM code.

Please refrain from modifying classes under org.springframework.asm, org.springframework.cglib, and org.springframework.objenesis. Those include repackaged forks of the third-party libraries ASM, CGLIB, and Objenesis. Any refactoring to those classes should take place upstream in the originating repository. The Spring Framework will then pick up the changes when syncing with official updates of the forked third-party libraries.

So I'll simply revert that change when merging.

@sbrannen sbrannen closed this in ab2c78a May 23, 2021
@sbrannen
Copy link
Member

This has been merged into main.

Thanks

@izeye izeye deleted the fix-javadoc-tags branch May 23, 2021 23:16
@izeye
Copy link
Contributor Author

izeye commented May 24, 2021

@sbrannen Thanks for the review and spotting the accidental change on the ASM module.

Out of curiosity, how did you notice all of those broken tags?

I just found one and then searched to fix similar occurrences.

@izeye
Copy link
Contributor Author

izeye commented May 24, 2021

I created https://gitlab.ow2.org/asm/asm/-/merge_requests/321 to fix it in the upstream module.

lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants