Introduce soft assertions for MockMvc #26917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wyhasany
force-pushed
the
feature/assert-softly
branch
2 times, most recently
from
4362294 to
2df94a6
Compare
sbrannen
changed the title
sbrannen
added
for: backport-to-4.3.x
in: web
sbrannen
added
type: enhancement
nguyensach
reviewed
May 10, 2021
spring-test/src/main/java/org/springframework/test/web/servlet/ResultMatcher.java
Outdated
Show resolved
Hide resolved
wyhasany
force-pushed
the
feature/assert-softly
branch
from
2329c2d to
c167134
Compare
|
@nguyensach I've applied your suggestions. Do you need any action on my side? |
kkocel
suggested changes
May 24, 2021
spring-test/src/main/java/org/springframework/test/web/servlet/ResultMatcher.java
Outdated
Show resolved
Hide resolved
wyhasany
force-pushed
the
feature/assert-softly
branch
from
c167134 to
5e7c51a
Compare
Co-authored-by: Sach Nguyen <[email protected]> It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertion could help a lot to check all conditions at once even if one of them fail.
wyhasany
force-pushed
the
feature/assert-softly
branch
from
5e7c51a to
438c40b
Compare
|
Current work on this issue can be seen in the following feature branch: main...sbrannen:issues/gh-26917-MockMvc-soft-assertions |
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 23, 2021
It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertions help a lot by checking all conditions at once even if one of them fails. See spring-projectsgh-26917 Co-authored-by: Sach Nguyen <[email protected]>
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 23, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 23, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 23, 2021
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 23, 2021
It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertions help a lot by checking all conditions at once even if one of them fails. See spring-projectsgh-26917 Co-authored-by: Sach Nguyen <[email protected]>
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 23, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Aug 23, 2021
|
Thanks for the PR, @wyhasany! 👍 This has been merged into In the end we decided to introduce a new |
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertions help a lot by checking all conditions at once even if one of them fails. See spring-projectsgh-26917 Co-authored-by: Sach Nguyen <[email protected]>
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens very often that MockMvc is used in
heavyweight integration tests. It's no use to waste
time to check if another condition has been fixed or
not. Soft assertion could help a lot to check all
conditions at once even if one of them fail.