Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Values from Mapping Path for Mvc Uri Builder #26914

Closed
wants to merge 1 commit into from
Closed

Resolve Values from Mapping Path for Mvc Uri Builder #26914

wants to merge 1 commit into from

Conversation

lower-case
Copy link

Fixes #26795

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 9, 2021
@rstoyanchev rstoyanchev added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Nov 10, 2021
rstoyanchev
rstoyanchev requested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the StringValueResolver should be an instance field, for use with the instance withXxx methods. And it needs test cases.

@rstoyanchev rstoyanchev self-assigned this Sep 26, 2022
@rstoyanchev rstoyanchev added the status: waiting-for-feedback We need additional information before we can continue label Sep 26, 2022
@snicoll
Copy link
Member

snicoll commented Aug 26, 2023

Closing due to lack of feedback.

@snicoll snicoll closed this Aug 26, 2023
@snicoll snicoll removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev requested changes

Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MvcUriComponentsBuilder should resolve property placeholders in request mapping paths
4 participants
@lower-case @snicoll @rstoyanchev @spring-projects-issues