Easier policy setters for ThreadPoolTaskScheduler. #26813
Conversation
…nd ContinueExistingPeriodicTasksAfterShutdown policies. This closes an existing issue: spring-projects#26719"
|
@Aelykto Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Aelykto Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
| @@ -64,6 +64,10 @@ | |||
|
|
|||
| private volatile boolean removeOnCancelPolicy; | |||
|
|
|||
| private volatile boolean executeExistingDelayedTasksAfterShutdownPolicy; | |||
There was a problem hiding this comment.
Default value in ScheduledThreadPoolExecutor is true. Does it matter if it's different?
There was a problem hiding this comment.
I believe you are actually correct and it matters for the getter:
if we don't have a scheduled executor inside our class - we return local value.
There was a problem hiding this comment.
fyi I added a default true value corresponding to scheduled thread pool executor
|
As per my comment on #26719, I ended up with a streamlined arrangement that does not include any policy getter methods. Thanks for the pull request, in any case! |
bclozel
removed
the
status: waiting-for-triage
Added an easier way to set ExecuteExistingDelayedTasksAfterShutdown and ContinueExistingPeriodicTasksAfterShutdown policies. This closes an existing issue: #26719"