Add support for explicit generic type in PayloadApplicationEvent #24599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: core
jhoeller
reviewed
Nov 30, 2021
spring-context/src/main/java/org/springframework/context/PayloadApplicationEvent.java
Outdated
Show resolved
Hide resolved
snicoll
removed
the
status: waiting-for-triage
chenqimiao
changed the title
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Dec 2, 2021
snicoll
added a commit
that referenced
this pull request
Dec 2, 2021
|
@chenqimiao thank you! |
|
@snicoll My pleasure |
|
org.springframework.context.event.ApplicationListenerMethodAdapter#onApplicationEvent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make event mechanisms better support generics.
When I publish an event which contains generics via
org.springframework.context.support.AbstractApplicationContext#publishEvent(java.lang.Object, org.springframework.core.ResolvableType), I find that corresponding listener does not get event message. Please see the unit test cases in my PR.The unit test method of named publishEventWithGeneric fail before this PR submission.So, I think we can add a payloadType field to PayloadApplicationEvent to fix this.
In addition, this fix code also can cache the type information of the payload to improve performance.
Thank you for reading and look forward to your reply.