-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadoc of ReactorResourceFactory#setConnectionProviderSupplier wrongly states it can be ignored #33338
Comments
It's making sure that |
yeah but i was pointing out that the comment says |
Thanks for following-up. Looks like I looked at the wrong branch. We'll have another look. |
ReactorResourceFactory
have wrong comments?
The phrasing is indeed misleading, and similarly in |
spring-framework/spring-web/src/main/java/org/springframework/http/client/ReactorResourceFactory.java
Lines 121 to 130 in 313b063
I wonder whether
useGlobalResources=false
option ignoresconnectionProviderSupplier
option or not cause the code seems it's notspring-framework/spring-web/src/main/java/org/springframework/http/client/ReactorResourceFactory.java
Lines 262 to 289 in 313b063
if i'm wrong enlighten me please
thank you in advance
The text was updated successfully, but these errors were encountered: