-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring AOP fails against registered @Configurable
aspect
#32838
Comments
I assume this is a side effect of #32793. Any special AspectJ aspects that you are declaring as a bean there but that are not meant to be picked up by Spring AOP? We consider ajc-compiled aspects as well now, simply backing out if they do not match. Also, the pointcut evaluation may happen more lazily now. I'm surprised this leads to new parser exceptions that propagate now; we were rather afraid that we might accidentally swallow parser exceptions, making it harder to debug the aspect setup. Since it is failing against a pointcut named |
We have no aspects declared in our code base, the third-party dependencies likely do. The only thing I see with One of the stack traces mentions Both fail when trying to construct |
@Configurable
aspect
I'm getting the same errors with spring 5.3.35 |
@NilsDammenhayn unfortunately that change got backported since it was driven by external integration needs in Micrometer. We'll release 6.1.8, 6.0.21 and 5.3.36 next week to fix this regression. |
This will be available in the upcoming 6.1.8, 6.0.21 and 5.3.36 snapshots. If you have the chance, please give any of them a try and let us know whether it fixes the issue for you... |
Tested the snapshot for 5.3.36 -> works! Thank you 🙏 |
Tested 6.1.8-SNAPSHOT -> works for us. thanks! |
EDIT: I now tested with Spring Framework 5.3.37-SNAPSHOT, and then I could not reproduce this problem. Thanks for fixing! :) I don't know if the problem I describe here is related to this issue, but post here since After upgrading Spring Framework from 5.3.34 to 5.3.36 we get the following stacktrace on startup:
|
After upgrading to 6.1.7 applications fail with various AOP errors:
Here are two examples (full stacks are below) from 2 different apps:
Caused by: java.lang.IllegalArgumentException: error at ::0 can't find referenced pointcut mostSpecificSubTypeConstruction
Caused by: java.lang.IllegalArgumentException: error Type referred to is not an annotation type: Configurable at org.aspectj.weaver.tools.PointcutParser.parsePointcutExpression(PointcutParser.java:319)
If I roll back to 6.1.6 everything is fine.
Note
org.aspectj:aspectjweaver:
is version1.9.22.1
(full dependency list below stack traces)The text was updated successfully, but these errors were encountered: