Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebClient Observations are missing error #32399

Closed
github-actions bot opened this issue Mar 8, 2024 · 1 comment
Closed

WebClient Observations are missing error #32399

github-actions bot opened this issue Mar 8, 2024 · 1 comment
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
6.0.18

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Backport of gh-32389
@github-actions github-actions bot added theme: observability An issue related to observability and tracing type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Mar 8, 2024
@github-actions github-actions bot added this to the 6.0.18 milestone Mar 8, 2024
@bclozel bclozel self-assigned this Mar 8, 2024
bclozel added a commit that referenced this issue Mar 8, 2024
@bclozel
Set error on observation in WebClient instrumentation
ec2c9b5 
Prior to this commit, error signals flowing from the client response
publisher in `WebClient` would be set on the `Observation.Context`. This
is enough for the observation convention to collect data about the error
but observation handlers are not notified of this error.

This commit sets the error instead on the observation directly to fix
this issue.

Fixes gh-32399
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Mar 8, 2024

Fixed via ec2c9b5

@github-actions github-actions bot closed this as completed Mar 8, 2024
@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
6.0.18
Development

No branches or pull requests
2 participants
@bclozel @jhoeller