Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hibernate substitutions and deprecated properties usage #32314

Closed
sdeleuze opened this issue Feb 22, 2024 · 1 comment
Closed

Remove Hibernate substitutions and deprecated properties usage #32314

sdeleuze opened this issue Feb 22, 2024 · 1 comment
Assignees
@sdeleuze
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Milestone
6.2.0-M2

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Feb 22, 2024 •
edited
Loading

As a follow-up of #32311, let's raise the baseline to Hibernate 6.5 (at least for native) in order to leverage https://hibernate.atlassian.net/browse/HHH-17568 and https://hibernate.atlassian.net/browse/HHH-17643 in order to remove the 2 Hibernate substitutions required to avoid Bytebuddy breaking native support with Hibernate.
@sdeleuze sdeleuze added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement labels Feb 22, 2024
@sdeleuze sdeleuze added this to the 6.2.0-M1 milestone Feb 22, 2024
@sdeleuze sdeleuze self-assigned this Feb 22, 2024
@sdeleuze sdeleuze mentioned this issue Feb 22, 2024
Closed
sdeleuze added a commit that referenced this issue Feb 22, 2024
@sdeleuze
Adapt Hibernate native support for HHH-17643
9430b24 
This commit adapts Hibernate native support to handle
the changes performed as part of HHH-17643 which impacts
Hibernate versions 6.4.3+ and 6.2.21+.

It ignores the BytecodeProvider services loaded by the
service loader feature in order to default to the
"no-op" provider with native, and makes the substitutions
more lenient when a substituted field or method does not
exist.

gh-32314 is expected to remove the need for such
substitutions which are not great for maintainability
by design.

Closes gh-32311
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Feb 22, 2024
@sdeleuze
Adapt Hibernate native support for HHH-17643
7686f54 
This commit adapts Hibernate native support to handle
the changes performed as part of HHH-17643 which impacts
Hibernate versions 6.4.3+ and 6.2.21+.

It ignores the BytecodeProvider services loaded by the
service loader feature in order to default to the
"no-op" provider with native.

spring-projectsgh-32314 is expected to remove the need for such
substitutions which are not great for maintainability
by design.

Closes spring-projectsgh-32312
@sdeleuze sdeleuze modified the milestones: 6.2.0-M1, 6.2.0-M2 Mar 20, 2024
@sdeleuze
Copy link
Contributor Author

Tested successfully with Petclinic and:

  • Removing Target_BytecodeProvider and Target_BytecodeProviderInitiator substitutions
  • Using Hibernate 6.5.0.Final and related metadata

@sdeleuze sdeleuze changed the title Remove Hibernate substitutions Remove Hibernate substitutions and deprecated properties usage Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M2
Development

No branches or pull requests
1 participant
@sdeleuze