DefaultRestClientBuilder.defaultRequest(...) doesn't do anything

[ThomasKasene]

DefaultRestClientBuilder.defaultClient(Consumer<RestClient.RequestHeadersSpec<?>>) can be used to set a property, but that property is never actually used when building the RestClient.

Is this related to #31625?

[injae-kim]

spring-framework/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClientBuilder.java

Lines 325 to 330 in 0c42965

	return new DefaultWebClient(exchange,
	filterFunctions,
	initUriBuilderFactory(),
	defaultHeaders,
	defaultCookies,
	this.defaultRequest,

spring-framework/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java

Lines 481 to 484 in 0c42965

	private ClientRequest.Builder initRequestBuilder() {
	if (defaultRequest != null) {
	defaultRequest.accept(this);
	}

Hi @poutsma ! I found that DefaultWebClient&Builder set&pass Consumer<WebClient.RequestHeadersSpec<?>> defaultRequest; from builder to client and DefaulltWebClient use it well on initRequestBuiilder() like above!

---

0820210 Introduce RestClient

spring-framework/spring-web/src/main/java/org/springframework/web/client/DefaultRestClientBuilder.java

Line 117 in 0c42965

private Consumer<RestClient.RequestHeadersSpec<?>> defaultRequest;

spring-framework/spring-web/src/main/java/org/springframework/web/client/DefaultRestClientBuilder.java

Lines 365 to 380 in 0c42965

	public RestClient build() {
	ClientHttpRequestFactory requestFactory = initRequestFactory();
	UriBuilderFactory uriBuilderFactory = initUriBuilderFactory();
	HttpHeaders defaultHeaders = copyDefaultHeaders();
	List<HttpMessageConverter<?>> messageConverters = (this.messageConverters != null ?
	this.messageConverters : initMessageConverters());
	return new DefaultRestClient(requestFactory,
	this.interceptors, this.initializers, uriBuilderFactory,
	defaultHeaders,
	this.statusHandlers,
	messageConverters,
	this.observationRegistry,
	this.observationConvention,
	new DefaultRestClientBuilder(this)
	);
	}

But on RestClient&Builder that introduced on above commit, I think we miss to pass defaultRequest from builder to DefaultRestClient on build() 😅
(also there's no unit test for defaultRequest on DefaultRestClient&Builder)

[injae-kim]

oh based on #31625, I'm not sure but maybe DefaultRestClientBuilder.defaultRequest is intended to be unused. (it's experimental feature?)

Waiting your opinion~! thanks!

Anyway, I created fix PR #32034 so feel free to close it if my fix is not what you want😃

[poutsma]

@ThomasKasene Indeed this was an oversight similar to #31625. In this case, however, we can enable support for the feature without making API changes, so I will commit a change shortly.

@injae-kim I did not see your PR until just now, and have already prepared a fix myself. Our fixes are fairly similar, by the looks of it, though I decided to follow the behaviour of WebClient more closely by invoking the request handler before the URI is initialised.

[injae-kim]

already prepared a fix myself

@poutsma aha then feel free to just close my PR~! if there's anything I can contribute or help, please share to me. thanks! 👍