Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForwardedHeaderFilter should reject invalid requests #31894

Closed
github-actions bot opened this issue Dec 22, 2023 · 1 comment
Closed

ForwardedHeaderFilter should reject invalid requests #31894

github-actions bot opened this issue Dec 22, 2023 · 1 comment
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
6.0.16

Comments

@github-actions
Copy link
Contributor

Backport of gh-31842
@github-actions github-actions bot added in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Dec 22, 2023
@github-actions github-actions bot added this to the 6.0.16 milestone Dec 22, 2023
bclozel added a commit that referenced this issue Dec 22, 2023
@bclozel
Reject invalid forwarded requests in ForwardedHeaderFilter
9d13ea2 
Prior to this commit, the `ForwardedHeaderFilter` and the forwarded
header utils would throw `IllegalArgumentException` and
`IllegalStateException` when request headers are invalid and cannot be
parsed for Forwarded handling.

This commit aligns the behavior with the WebFlux counterpart by
rejecting such requests with HTTP 400 responses directly.

Fixes gh-31894
@bclozel bclozel self-assigned this Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor Author

Fixed via 9d13ea2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
6.0.16
Development

No branches or pull requests
1 participant
@bclozel