Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceId is missing in WebFlux controller handlers #31706

Closed
nstdio opened this issue Nov 28, 2023 · 2 comments
Closed

TraceId is missing in WebFlux controller handlers #31706

nstdio opened this issue Nov 28, 2023 · 2 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches theme: observability An issue related to observability and tracing type: regression A bug that is also a regression
Milestone
6.1.2

Comments

@nstdio
Copy link

nstdio commented Nov 28, 2023 •
edited
Loading

We upgraded from Spring Boot 3.1.5 to 3.1.6 and trace id and span id are missing from the logs. However, it's not only a logging issue but also baggage is lost too.

Please find an example application demonstrating the issue: demo.zip. You can change Spring Boot version from build.gradle.kts to 3.1.5 and see that trace id and span id are present in the logs.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 28, 2023
@wilkinsona wilkinsona changed the title TranceId/SpanId are missing with Spring Boot 3.1.6 and WebFlux TraceId/SpanId are missing with Spring Boot 3.1.6 and WebFlux Nov 28, 2023
@wilkinsona
Copy link
Member

Thanks for the sample. This appears to be a regression in Spring Framework 6.0.14. The problem does not occur with Spring Boot 3.1.6 when Framework is downgraded to 6.0.13 but it does occur with Spring Boot 3.1.5 when Framework is upgraded to 6.0.14. We'll transfer this issue to the Framework team so that they can continue the investigation.

@bclozel bclozel transferred this issue from spring-projects/spring-boot Nov 28, 2023
@bclozel bclozel self-assigned this Nov 28, 2023
@bclozel
Copy link
Member

bclozel commented Nov 28, 2023

This is due to a regression introduced by #31417.

@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression theme: observability An issue related to observability and tracing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 28, 2023
@bclozel bclozel added this to the 6.1.2 milestone Nov 28, 2023
This was referenced Nov 28, 2023
Closed
Closed
@sdeleuze sdeleuze mentioned this issue Nov 29, 2023
Open
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-6.0.x labels Nov 29, 2023
@github-actions github-actions bot mentioned this issue Nov 29, 2023
Closed
@bclozel bclozel changed the title TraceId/SpanId are missing with Spring Boot 3.1.6 and WebFlux TraceId is missing in WebFlux controller handlers Nov 29, 2023
This was referenced Dec 1, 2023
Closed
Closed
@bclozel bclozel mentioned this issue Dec 5, 2023
Closed
@bclozel bclozel mentioned this issue Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches theme: observability An issue related to observability and tracing type: regression A bug that is also a regression
Projects
None yet
Milestone
6.1.2
Development

No branches or pull requests
4 participants
@bclozel @wilkinsona @spring-projects-issues @nstdio