Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer - Baggage propagation behaves differently between functional router and controller #39036

Closed
arana3 opened this issue Jan 5, 2024 · 3 comments
Labels
status: duplicate A duplicate of another issue status: invalid An issue that we don't feel is valid

Comments

@arana3
Copy link

arana3 commented Jan 5, 2024

Bug report

Description:

  • RestController annotated HTTP input properly takes custom baggage (ex. "management.tracing.baggage.correlation.fields") and propagates remotely (ex. Kafka)
  • Functional router HTTP input does not take custom baggage out of box and propagate remotely (e.g. Kafka)

Screenshot links

Rest Controller HTTP input --> Kafka msg record headers

Functional Router

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 5, 2024
@wilkinsona
Copy link
Member

Thanks for the report. Unfortunately, the screenshots are so small and heavily compressed that they're unreadable. Can you please either copy the text into this issue or attach the images directly.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jan 5, 2024
@bclozel
Copy link
Member

bclozel commented Jan 5, 2024

I've tried your sample and unfortunately it doesn't run for me. For future reports, it would be useful to provide more detailed explanations on how to reproduce the problem: do we need to have a particular container running (in this case, can you provide a docker compose?). Is Kafka really needed?

Here, the missing trace is not really related to Kafka at all and I've stripped Kafka from your sample. Upgrading to Spring 3.2.1 fixes the problem so I assume this is a duplicate of spring-projects/spring-framework#31706 and I'm closing this issue as a result.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
@bclozel bclozel added status: duplicate A duplicate of another issue status: invalid An issue that we don't feel is valid and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jan 5, 2024
@arana3
Copy link
Author

arana3 commented Jan 5, 2024

Thanks @bclozel.

I did not find that mentioned issue in my search (was using keyword observability). I see that recently released Spring Boot 3.2.1 and its dependencies resolves the issue.

Correlation fields marked for propagation from baggage are now propagating via Kafka and HTTP using the reactive web client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

4 participants