Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current Observation.Context missing from WebClient request #31646

Closed
github-actions bot opened this issue Nov 21, 2023 · 1 comment
Closed

Current Observation.Context missing from WebClient request #31646

github-actions bot opened this issue Nov 21, 2023 · 1 comment
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
6.0.15

Comments

@github-actions
Copy link
Contributor

Backport of gh-31609
@github-actions github-actions bot added in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Nov 21, 2023
@github-actions github-actions bot added this to the 6.0.15 milestone Nov 21, 2023
@bclozel bclozel changed the title Cannot add custom observation KeyValues from ExchangeFilterFunctions Current Observation.Context missing from WebClient request Nov 24, 2023
@github-actions GitHub Actions
Copy link
Contributor Author

Fixed via 2baf064

bclozel added a commit that referenced this issue Nov 24, 2023
@bclozel
Add current observation context in ClientRequest
2baf064 
Prior to this commit, `ExchangeFilterFunction` could only get the
current observation from the reactor context. This is particularly
useful when such filters want to add KeyValues to the observation
context.

This commit makes this use case easier by adding the context of the
current observation as a request attribute. This also aligns the
behavior with other instrumentations.

Fixes gh-31646
jhoeller added a commit that referenced this issue Jan 24, 2024
@jhoeller
Declare current observation context as available since 6.0.15
3817936 
See gh-31609
See gh-31646
jhoeller added a commit that referenced this issue Jan 24, 2024
@jhoeller
Declare current observation context as available since 6.0.15
199a675 
See gh-31609
See gh-31646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
6.0.15
Development

No branches or pull requests
1 participant
@bclozel