Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double proxying for @Resource @Lazy fallback autowiring #31447

Closed
jhoeller opened this issue Oct 17, 2023 · 0 comments
Closed

Avoid double proxying for @Resource @Lazy fallback autowiring #31447

jhoeller opened this issue Oct 17, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.1.2

Comments

@jhoeller
Copy link
Contributor

The @Lazy support for @Resource injection points (as implemented in CommonAnnotationBeanPostProcessor) can lead to double proxying in case of fallback autowiring when no bean of the given name could be found, since DefaultListableBeanFactory.resolveDependency performs its own lazy proxy resolution in such a scenario. Addressing this through a refactored resolution algorithm also aligns with our upcoming AOT support for @Resource (#29614).
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Oct 17, 2023
@jhoeller jhoeller added this to the 6.1.0-RC2 milestone Oct 17, 2023
@jhoeller jhoeller self-assigned this Oct 17, 2023
@jhoeller jhoeller changed the title Avoid double proxying for @Resource fallback autowiring Avoid double proxying for @Resource @Lazy fallback autowiring Oct 23, 2023
@jhoeller jhoeller changed the title Avoid double proxying for @Resource @Lazy fallback autowiring Avoid double proxying for @Resource @Lazy fallback autowiring Oct 23, 2023
@jhoeller jhoeller modified the milestones: 6.1.0-RC2, 6.1.x Oct 23, 2023
jhoeller added a commit that referenced this issue Oct 23, 2023
@jhoeller
Test for @resource @lazy fallback type match
d2108d2 
See gh-31447
jhoeller added a commit that referenced this issue Oct 23, 2023
@jhoeller
Test for @resource @lazy fallback type match
6809395 
See gh-31447
@jhoeller jhoeller modified the milestones: 6.1.x, 6.1.2 Dec 11, 2023
@jhoeller jhoeller mentioned this issue Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.2
Development

No branches or pull requests
1 participant
@jhoeller