Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Documentation Around X-Forwarded- Headers #31273

Closed
rwinch opened this issue Sep 19, 2023 · 1 comment
Closed

Improve Documentation Around X-Forwarded- Headers #31273

rwinch opened this issue Sep 19, 2023 · 1 comment
Assignees
@rwinch
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: documentation A documentation task

Comments

@rwinch
Copy link
Member

rwinch commented Sep 19, 2023 •
edited
Loading

Affects: 6.0.12

Spring could improve the documentation (both reference and Javadoc) around X-Forwarded-* headers. In particular, the X-Forwarded-Prefix header could use some clarifications as demonstrated in #31241

I've discussed this with @rstoyanchev and I'm happy to send a PR with my comment as a starting point for the updated documentation.
@rwinch rwinch mentioned this issue Sep 19, 2023
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 19, 2023
@rstoyanchev rstoyanchev added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 19, 2023
@rstoyanchev rstoyanchev added this to the 6.0.13 milestone Sep 19, 2023
@bclozel bclozel modified the milestones: 6.0.13, 6.0.14 Oct 12, 2023
rwinch added a commit to rwinch/spring-framework that referenced this issue Oct 25, 2023
@rwinch
Document X-Forwarded-* Headers
55d6a3a 
Previously the documentation assumed that the readers knew how to use
the X-Forwarded-* headers.

This commit documents details & examples of how to use the X-Forwarded-*
headers.

Closes spring-projectsgh-31273
@rwinch rwinch mentioned this issue Oct 25, 2023
Closed
@snicoll
Copy link
Member

snicoll commented Oct 25, 2023 •
edited
Loading

Closing in favor of PR #31491

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Oct 25, 2023
@snicoll snicoll removed this from the 6.0.14 milestone Oct 25, 2023
@rwinch rwinch moved this to Done in Spring Security Team Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: documentation A documentation task
Projects
Spring Security Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document X-Forwarded-* Headers rwinch/spring-framework
5 participants
@bclozel @rwinch @rstoyanchev @snicoll @spring-projects-issues