Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHttpHandlerBuilder should auto-detect observability beans #31205

Closed
bclozel opened this issue Sep 11, 2023 · 0 comments
Closed

WebHttpHandlerBuilder should auto-detect observability beans #31205

bclozel opened this issue Sep 11, 2023 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing
Milestone
6.1.0-M5

Comments

@bclozel
Copy link
Member

bclozel commented Sep 11, 2023

As of #30013, the HTTP server observability infrastructure is configured directly on the WebHttpHandlerBuilder.
All other components set on that builder are also automatically detected if they are present in the application context. We should align the behavior there for both ObservationRegsitry and ServerRequestObservationConvention.
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing labels Sep 11, 2023
@bclozel bclozel added this to the 6.1.0-M5 milestone Sep 11, 2023
@bclozel bclozel self-assigned this Sep 11, 2023
@bclozel bclozel mentioned this issue Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing
Projects
None yet
Milestone
6.1.0-M5
Development

No branches or pull requests
1 participant
@bclozel