Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated ServerHttpObservationFilter for WebFlux instrumentation #37344

Closed
bclozel opened this issue Sep 12, 2023 · 0 comments
Closed

Remove usage of deprecated ServerHttpObservationFilter for WebFlux instrumentation #37344

bclozel opened this issue Sep 12, 2023 · 0 comments
Assignees
@bclozel
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone
3.2.0-M3

Comments

@bclozel
Copy link
Member

bclozel commented Sep 12, 2023

Since spring-projects/spring-framework#30013, the ServerHttpObservationFilter is deprecated because its position in the WebFlux stack doesn't allow it to record observations accurately. This is being replaced by an instrumentation at the WebHttpHandlerBuilder level, which now auto-detects the ObservationRegistry bean in the context along others (see spring-projects/spring-framework#31205).

We should update our auto-configuration arrangement here to remove the ServerHttpObservationFilter setup and only rely on the Framework detection in the application context for the instrumentation of the WebHttpHandlerBuilder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.0-M3
Development

No branches or pull requests
1 participant
@bclozel