Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring LogFactory implementation deviates from original Apache LogFactory in terms of abstract method declarations #31166

Closed
Vituratic opened this issue Sep 4, 2023 · 0 comments
Closed

Spring LogFactory implementation deviates from original Apache LogFactory in terms of abstract method declarations #31166

Vituratic opened this issue Sep 4, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: regression A bug that is also a regression
Milestone
6.0.12

Comments

@Vituratic
Copy link

Affects: spring-jcl 5.3.29

For the Spring version 5.3.29 the commit c7bc40d has been added. There seems to be an issue with this, breaking one of our projects, when we try to update from 5.3.28:
We are using the jaxb2-maven-plugin in version 2.5.0 with the additional dependency jaxb-xew-plugin in version 1.11. If we try to compile after updating we get the following error message:

Receiver class org.apache.commons.logging.LogFactoryService does not define or inherit an implementation of the resolved method 'abstract void release()' of abstract class org.apache.commons.logging.LogFactory.

Within xew they are using org.apache.commons.logging.LogFactory#release. From my understanding the issue is caused, because in the original implementation as of commons-logging 1.2 the release() method is abstract, while in spring-jcl it is not.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 4, 2023
@jhoeller jhoeller added type: regression A bug that is also a regression in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 4, 2023
@jhoeller jhoeller self-assigned this Sep 4, 2023
@jhoeller jhoeller added this to the 6.0.12 milestone Sep 4, 2023
@jhoeller jhoeller changed the title Springs LogFactory implementation deviates from Apaches LogFactory implementation Spring' LogFactory implementation deviates from original Apache LogFactory in terms of abstract method declarations Sep 4, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Sep 4, 2023
@github-actions github-actions bot mentioned this issue Sep 4, 2023
Closed
@jhoeller jhoeller changed the title Spring' LogFactory implementation deviates from original Apache LogFactory in terms of abstract method declarations Spring LogFactory implementation deviates from original Apache LogFactory in terms of abstract method declarations Sep 4, 2023
jhoeller added a commit that referenced this issue Sep 11, 2023
@jhoeller
Align abstract method signatures with original Commons Logging API
0c3d8d7 
Closes gh-31166

(cherry picked from commit 268043e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: regression A bug that is also a regression
Projects
None yet
Milestone
6.0.12
Development

No branches or pull requests
3 participants
@jhoeller @spring-projects-issues @Vituratic