Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Constants utility and stop using it internally #30851

Closed
16 tasks done
sbrannen opened this issue Jul 10, 2023 · 2 comments
Closed
16 tasks done

Deprecate Constants utility and stop using it internally #30851

sbrannen opened this issue Jul 10, 2023 · 2 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.1.0-M4

Comments

@sbrannen
Copy link
Member

sbrannen commented Jul 10, 2023 •
edited
Loading

Overview

As discussed in #30846 (comment), since Constants is an outdated utility that uses reflection (which is not native-friendly), we should deprecate Constants and stop using it internally.

Related Issues

Deliverables

  • Deprecate Constants.
  • Stop using Constants in the code base.
    • spring-context
      • MBeanExporter
    • spring-aop
      • CustomizableTraceInterceptor
    • spring-beans
      • PropertyPlaceholderConfigurer
      • XmlBeanDefinitionReader
    • spring-context-support
      • CronTriggerFactoryBean
      • SimpleTriggerFactoryBean
    • spring-jdbc
      • IsolationLevelDataSourceAdapter
      • LazyConnectionDataSourceProxy
      • IsolationLevelDataSourceRouter
    • spring-jms
      • DefaultMessageListenerContainer
      • JmsActivationSpecConfig
      • JmsAccessor
    • spring-tx
      • AbstractPlatformTransactionManager
      • DefaultTransactionDefinition
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Jul 10, 2023
@sbrannen sbrannen added this to the 6.1.0-M3 milestone Jul 10, 2023
@sbrannen sbrannen self-assigned this Jul 10, 2023
@sbrannen sbrannen mentioned this issue Jul 10, 2023
Closed
@sbrannen sbrannen changed the title Avoid use of reflection via Constants in MBeanExporter Deprecate Constants and stop using it internally Jul 10, 2023
@sbrannen sbrannen mentioned this issue Jul 10, 2023
Closed
sbrannen added a commit that referenced this issue Jul 10, 2023
@sbrannen
Avoid need for reflection hints for MBeanExporter in native image
679b668 
Prior to this commit, MBeanExporter used
org.springframework.core.Constants which used reflection to find
constant fields in the MBeanExporter class. Consequently, one had to
register reflection hints in order to use MBeanExporter in a GraalVM
native image.

This commit addresses this by replacing the use of the `Constants`
class with a simple java.util.Map which maps constant names to constant
values for the autodetect constants defined in MBeanExporter.

See gh-30851
Closes gh-30846
@sbrannen
Copy link
Member Author

See commit 679b668 for an example of how Constants can be replaced by a simple Map in some use cases.

sbrannen added a commit that referenced this issue Jul 16, 2023
@sbrannen
Stop using Constants utility in CustomizableTraceInterceptor
f01fb19 
See gh-30851
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jul 16, 2023
@sbrannen
Stop using Constants utility in PropertyPlaceholderConfigurer
a92bd42 
See spring-projectsgh-30851
sbrannen added a commit that referenced this issue Jul 16, 2023
@sbrannen
Stop using Constants utility in XmlBeanDefinitionReader
6f73351 
See gh-30851
@sbrannen sbrannen changed the title Deprecate Constants and stop using it internally Deprecate Constants utility and stop using it internally Jul 16, 2023
sbrannen added a commit that referenced this issue Jul 16, 2023
@sbrannen
Remove cross reference to Constants utility
635cd29 
See gh-30851
sbrannen added a commit that referenced this issue Jul 16, 2023
@sbrannen
Stop using Constants utility in CronTriggerFactoryBean
edba535 
See gh-30851
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jul 16, 2023
@sbrannen
Stop using Constants utility in SimpleTriggerFactoryBean
d623082 
See spring-projectsgh-30851
sbrannen added a commit that referenced this issue Jul 16, 2023
@sbrannen
Stop using Constants utility in DefaultMessageListenerContainer
3a8b511 
See gh-30851
@jhoeller jhoeller modified the milestones: 6.1.0-M3, 6.1.0-M4 Jul 17, 2023
sbrannen added a commit that referenced this issue Jul 19, 2023
@sbrannen
Stop using Constants utility in JmsActivationSpecConfig
4e00c98 
See gh-30851
sbrannen added a commit that referenced this issue Jul 19, 2023
@sbrannen
Stop using Constants utility in JmsAccessor
b2ca36f 
See gh-30851
sbrannen added a commit that referenced this issue Jul 19, 2023
@sbrannen
Stop using Constants utility in DefaultTransactionDefinition
d0076f5 
See gh-30851
sbrannen added a commit that referenced this issue Jul 19, 2023
@sbrannen
Stop using Constants utility in AbstractPlatformTransactionManager
97810c8 
See gh-30851
sbrannen added a commit that referenced this issue Jul 19, 2023
@sbrannen
Stop using Constants utility in IsolationLevelDataSourceAdapter
9571aa1 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Stop using Constants utility in LazyConnectionDataSourceProxy
cc92786 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Assert LazyConnectionDataSourceProxy.setDefaultTransactionIsolation()…
48eb477 
… values

See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Polish tests for configuration constants
0eda441 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Stop using Constants utility in IsolationLevelDataSourceRouter
06c6af9 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Assert XmlBeanDefinitionReader.setValidationMode() values
12f765c 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Assert CronTriggerFactoryBean.setMisfireInstruction() values
1378cce 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Assert SimpleTriggerFactoryBean.setMisfireInstruction() values
81181c3 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Assert DefaultMessageListenerContainer.setCacheLevel() values
b45bfca 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Assert JmsActivationSpecConfig.setAcknowledgeMode() values
9da318a 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Assert JmsAccessor.setSessionAcknowledgeMode() values
3b8dd0a 
See gh-30851
sbrannen added a commit that referenced this issue Jul 31, 2023
@sbrannen
Replace map entry traversal with switch expression
bcff7d7 
See gh-30851
@snicoll
Copy link
Member

snicoll commented Sep 29, 2023

See #31328 - I wonder if a review of the changes above should be considered to see if a similar restriction was introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M4
Development

No branches or pull requests
3 participants
@sbrannen @snicoll @jhoeller