Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RuntimeHintsAgentPlugin to use the native image code path #30422

Closed
sdeleuze opened this issue May 4, 2023 · 0 comments
Closed

Update RuntimeHintsAgentPlugin to use the native image code path #30422

sdeleuze opened this issue May 4, 2023 · 0 comments
Assignees
@sdeleuze
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.1.0-M1

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented May 4, 2023

RuntimeHintsAgentPlugin purpose is to verify that reflective invocations expected match the ones performed.

gh-30242 introduces a code path where the reflective invocation is skipped when running on native.

This issue set the system property org.graalvm.nativeimage.imagecode to runtime when running runtime tests with the agent in order to make sure the code path tested for those tests is the native one.
@sdeleuze sdeleuze added in: test Issues in the test module type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels May 4, 2023
@sdeleuze sdeleuze added this to the 6.1.0-M1 milestone May 4, 2023
@sdeleuze sdeleuze self-assigned this May 4, 2023
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue May 4, 2023
@sdeleuze
Skip CRaC support with native images
9fec516 
Skip CRaC support with native images to avoid compiling related
infrastructure to the native image and to fix tests via
spring-projectsgh-30422.

See spring-projectsgh-30242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

No branches or pull requests
1 participant
@sdeleuze